Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a utf-8 header to all .py files. #557

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Added a utf-8 header to all .py files. #557

merged 1 commit into from
Oct 26, 2023

Conversation

dblock
Copy link
Member

@dblock dblock commented Oct 26, 2023 •
edited
Loading

Description

Consistently add a utf-8 header to all .py files.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Oct 26, 2023 •
edited
Loading

Codecov Report

Merging #557 (0850624) into main (5c7fe9d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #557   +/-   ##
=======================================
  Coverage   71.10%   71.10%           
=======================================
  Files          85       85           
  Lines        7774     7774           
=======================================
  Hits         5528     5528           
  Misses       2246     2246
Files Coverage Δ
opensearchpy/__init__.py 100.00% <ø> (ø)
opensearchpy/_async/_extra_imports.py 71.42% <ø> (ø)
opensearchpy/_async/client/_patch.py 46.15% <ø> (ø)
opensearchpy/_async/client/cat.py 65.78% <ø> (ø)
opensearchpy/_async/client/cluster.py 51.76% <ø> (ø)
opensearchpy/_async/client/dangling_indices.py 53.33% <ø> (ø)
opensearchpy/_async/client/features.py 75.00% <ø> (ø)
opensearchpy/_async/client/indices.py 46.22% <ø> (ø)
opensearchpy/_async/client/ingest.py 50.00% <ø> (ø)
opensearchpy/_async/client/nodes.py 63.15% <ø> (ø)
... and 73 more

@dblock dblock changed the title Added UTF-8 BOM everywhere. Added a utf-8 header to all .py files. Oct 26, 2023
@dblock dblock merged commit 0da60b2 into opensearch-project:main Oct 26, 2023
55 checks passed
@dblock dblock deleted the utf-8 branch October 26, 2023 17:34
@jayaddison
Copy link
Contributor

@dblock an extremely pedantic note while reviewing changes from v2.3.2 to v2.4.2 - it looks like a couple of these encoding declarations dropped out when bcfef11 was committed (run_tests.py here and generate-api.py here).

Hopefully not a problem in itself, but perhaps an indication of some utility/process that should have left those lines intact.

@dblock
Copy link
Member Author

dblock commented Nov 21, 2023

@dblock an extremely pedantic note while reviewing changes from v2.3.2 to v2.4.2 - it looks like a couple of these encoding declarations dropped out when bcfef11 was committed (run_tests.py here and generate-api.py here).

Hopefully not a problem in itself, but perhaps an indication of some utility/process that should have left those lines intact.

Yep, this is a problem :(

@dblock dblock mentioned this pull request Nov 21, 2023
Closed
@dblock
Copy link
Member Author

dblock commented Nov 21, 2023

@jayaddison I opened #613. Maybe you want to tackle it? Ideally there's a pylint rule/linter that ensures these are present everywhere, or maybe we'll need to write one.

@jayaddison
Copy link
Contributor

Possibly, yep - I'll follow along in that thread (and have asked a question about the reason for the coding declarations).

roma2023 pushed a commit to roma2023/opensearch-py that referenced this pull request Dec 28, 2023
@dblock @roma2023
Added a utf-8 header to all .py files (opensearch-project#557)
4f51d9c 
Signed-off-by: dblock <[email protected]>
Signed-off-by: roma2023 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VachaShah VachaShah VachaShah approved these changes

@harshavamsi harshavamsi Awaiting requested review from harshavamsi harshavamsi is a code owner

@axeoman axeoman Awaiting requested review from axeoman axeoman is a code owner

@deztructor deztructor Awaiting requested review from deztructor

@Shephalimittal Shephalimittal Awaiting requested review from Shephalimittal Shephalimittal is a code owner

@saimedhi saimedhi Awaiting requested review from saimedhi saimedhi is a code owner

@florianvazelle florianvazelle Awaiting requested review from florianvazelle florianvazelle is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dblock @jayaddison @VachaShah